rqt_bag does not position icons correctly on OS X

[wjwwood]

See answers.ros.org post here:

http://answers.ros.org/question/60017/rqt-not-showing-icons-in-osx/

[ablasdel]

This must be a bug in Qt on OS X since these items are just fixed size buttons in a horizontal layout. Nothing fancy is going on. I've read that OS X qt sometimes handles drawing a bit differently than other platforms but this seems to be a bit over the top. Unfortunately I haven't found any reference to this kind of issue specifically.

[wjwwood]

The refresh icon is not sized properly:

[ablasdel]

This bug might be better represented on the rqt package since, as you have just shown with that shot, it is not at the rqt_bag level. I will make a bug that links here.

[ablasdel]

I am closing this bug as a duplicate of ros-visualization/rqt#83 because it is better tracked in ros-visualization/rqt since it is a global rqt (really qt) problem.

[wjwwood]

If I unset the maximum size for the buttons in Qt Designer it looks more reasonable, but the buttons are still huge:

[wjwwood]

(I added that CheckBox while testing)

[ablasdel]

This looks good honestly. I'll check your fork on Ubuntu and if it looks ok I think this is an improvement on before.

[ablasdel]

Reopening because we can (hopefully) work around the bug specifically for rqt_bag!

@wjwwood can you try this commit hash and give me a screenshot of what it looks like for you on osx?
ablasdel@24fd942

On ubuntu it looks like this:

[wjwwood]

I upgraded this to a pull request, can you test this on Ubuntu, this is what it currently looks like on OS X:

[ablasdel]

This merge makes the buttons a touch wider on ubuntu but that is fine.

I'm a bit worried about your last 4 buttons not having any icons. Do they still work?

[dirk-thomas]

Let me compare this with other ui files before the merge.

[ablasdel]

Console for example doesn't even set a size on its buttons: https://github.com/ros-visualization/rqt_common_plugins/blob/hydro-devel/rqt_console/resource/console_widget.ui#L29

[ablasdel]

I removed the "maximumSize" property entirely and it behaves the same as that pull request.

[dirk-thomas]

By default the ui file does not contain any properties. So instead of setting the values to 16777215 you should indeed "reset" that property in QtCreator which will effectively remove the property from the ui file. Please update the pull request accordingly.

[ablasdel]

I've done that in this commit
ablasdel@15ea675

That way we don't have to waste anymore of williams precious time.

[ablasdel]

If I merge this will it merge william's and mine?
new and interesting git questions every day.

[ablasdel]

I'll merge this at ~7-8ish if there is no complaint here by then.

Thanks for the help will/dirk

[wjwwood]

Updated.

[dirk-thomas]

Looks good now. I will do the merge...

[jf---]

To what extent might this be Retina / HighDPI related?
This is known to be a bit buggy on Qt 4.10

[dirk-thomas]

I think what you are referring to is more related to #83. We have added an explicit iconSize (eafed12). Even if 16x16 should be default value on OS X it did not work correctly without setting the iconSize explicitly.

[jf---]

dirk, indeed clearly not. thanks helping me get up to speed, sorry for the noise.