Fix Windows conflicting macros and missing usleep #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could someone help me figure out what's going on with the latest test failures? I'm not super familiar with Jenkins, but I see there's only one that's a fresh failure, but I'm not sure where to go from here. Thanks! |
This was referenced Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issue mentioned here: #884
<windows.h>is included indirectly via gazebo, which causes conflicts within gazebo_ros_packages and in included ros2 headers.OUTis a macro in Windows and used in templates in gazebo_ros. Fixed by changing toT.NO_ERRORis a macro in Windows and used in tf2 in ros2. Fixed with#undef.usleepdoes not exist in Windows. Fixed with macro.