Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to AWS warehouse simulation scenario #2797
Migrate to AWS warehouse simulation scenario #2797
Changes from 13 commits
15d4aa8
bdb933b
5b18241
641e1c5
a60017b
1c24b6d
cd1adde
ccc295a
801a0e3
715b0c7
0482c8d
53e84d9
7f634a3
b353c01
a31b528
50317bd
ff6c820
cf4f7ae
2962c25
c03a8e0
ac33d9c
49a14d8
0b54780
ca860b7
fbd7496
f6b187e
d22d052
45d6728
4e5ba4b
cff74fe
f74fc15
00658a0
cbb2aa8
5af0419
84f6fbd
e33db07
264347d
017f10f
5137875
d6c031b
68b3cc9
16d7698
8df9acd
30888a5
9f417d6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing gazebo? Wouldn't we have multiple instances of it running if each of the
n
robots starts their own? I thought we did that here so that it didn't get done there so they all shared 1 and we set the gazebo parameters to false within each's launch (e.g. https://github.com/ros-planning/navigation2/blob/7f634a3993bd5e129c5b5b220795df9a09a332bd/nav2_bringup/launch/multi_tb3_simulation_launch.py#L133). I think gazebo needs to be launched here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You were right. I misunderstood the use of that parameter. Anyway, I'm having some problem: map is not load correctly, so the simulation is not working properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did that get worked out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Still debugging it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK!
This file was deleted.
This file was deleted.
This file was deleted.