Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter warnings for nav2_util pf, sensor, and laser #133

Closed
mhpanah opened this issue Oct 2, 2018 · 3 comments
Closed

Fix linter warnings for nav2_util pf, sensor, and laser #133

mhpanah opened this issue Oct 2, 2018 · 3 comments
Assignees
@mhpanah
Labels
enhancement New feature or request nav2_localization
Milestone
October 2018

Comments

@mhpanah
Copy link
Contributor

mhpanah commented Oct 2, 2018

Fix all linter issues in nav2_util for:
sensor
pf
map
@mhpanah mhpanah added enhancement New feature or request nav2_localization labels Oct 2, 2018
@mhpanah mhpanah added this to the October 2018 milestone Oct 2, 2018
@mhpanah mhpanah self-assigned this Oct 2, 2018
@mhpanah mhpanah mentioned this issue Oct 2, 2018
Merged
@ghost
Copy link

ghost commented Oct 3, 2018

This looks like a duplicate of #71

@mhpanah
Copy link
Contributor Author

mhpanah commented Oct 3, 2018

Fixed in PR#134.

@mhpanah mhpanah closed this as completed Oct 3, 2018
@mhpanah
Copy link
Contributor Author

mhpanah commented Oct 3, 2018

@crdelsey We still need to fix linter warnings for map_loader and costmap. So let's not close #71 yet.

ghost pushed a commit to logivations/navigation2 that referenced this issue Mar 7, 2022
AMRFM-989-ros2-launch (ros-navigation#133)
cba96f2 
* initial commit

* using original joy package

* cleaning imports

* Enabled only agv_gazebo and amr_description

* Added navigation to launch file

* Added monitoring

* default gui to true

* amr_bringup dependecies

* minor fixes

* remove unused param

* removed camera server processes

* potential fix for enable_cameras

* renaming

* fixed renaming

* removed duplicate amr_communicator

* Add rviz config

* Added respawn for most nodes

* add nice

* Add nice priorities

* Add RCUTILS_CONSOLE_STDOUT_LINE_BUFFERED
mini-1235 pushed a commit to mini-1235/navigation2 that referenced this issue Feb 5, 2025
@deepaktalwardt
Rename instances of laser_link to base_laser (ros-navigation#133)
817d912 
All instances of `laser_link` are updated to `base_laser` for consistency with figures in this guide.
Forsyth-Creations pushed a commit to Forsyth-Creations/navigation2 that referenced this issue Feb 19, 2025
@bmagyar @destogl
Restore forward command derivatives (ros-navigation#133)
14733fe 
* forward_command_controller only checks "interface_name" parameter when
member var is not set

* Restore position_controllers package

* Restore velocity_controllers

* Restore effort_controllers package

* Add restored controllers to source build

* Update forward_command_controller/src/forward_command_controller.cpp

Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>

* Update position_controllers/src/joint_group_position_controller.cpp

Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>

* Update position_controllers/test/test_joint_group_position_controller.hpp

Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>

* fix pluginlib boost

* Add group controllers to metapackage

* Remove colcon ignore from ros2_controllers

Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhpanah mhpanah

Labels
enhancement New feature or request nav2_localization
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
1 participant
@mhpanah