-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs for iterative graceful controller #624
Conversation
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
TODO (after review and updates to underlying PR):
|
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending underlying PR.
Only thing would be to add in the migration guide that we adjusted some parameters and list just the changed parameters for folks to be aware of
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikeferguson a few additions:
- You changed the defaults of the k/beta parameters, the new defaults should be updated in this table
- In the migration guide, we should mention this (Pretty big) change
- In the Navigation Plugins table, I'd add in omni as supported motion models (not just diff)
Where in the migration doc do we want this? The Jazzy->K-turtle part, or are we planning to backport at all? |
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
Since it changes and removes parameters, it cannot be backported, so J->K |
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
Signed-off-by: Michael Ferguson <mfergs7@gmail.com>
@SteveMacenski - added requested items - I think this ready for a final review |
* update docs for iterative graceful controller Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * add add_orientations Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * updates after review comments Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * additional review udpates Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * update notes on initial rotation tolerance Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * trailing whitespace Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * update defaults for control law Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * add omni, legged Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * update migration docs Signed-off-by: Michael Ferguson <mfergs7@gmail.com> * spelling/linter Signed-off-by: Michael Ferguson <mfergs7@gmail.com> --------- Signed-off-by: Michael Ferguson <mfergs7@gmail.com> Signed-off-by: John Chrosniak <chrosniakj@gmail.com>
Doc changes for ros-navigation/navigation2#4795