Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document bt_navigator error_code_name_prefixes and error_msg #587

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

aosmw
Copy link

@aosmw aosmw commented Aug 31, 2024

Documents featured added to support returning Error codes and messages from failed NavigateToPose/NavigateThroughPoses actions ros-navigation/navigation2#4341

@aosmw aosmw marked this pull request as draft August 31, 2024 10:17
@aosmw aosmw force-pushed the feature/mw/bt_error_msg_586 branch 2 times, most recently from 795dcae to 23e4b92 Compare August 31, 2024 10:28
@aosmw aosmw marked this pull request as ready for review August 31, 2024 10:53
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM

@aosmw aosmw force-pushed the feature/mw/bt_error_msg_586 branch from 8d20961 to ed98c63 Compare September 7, 2024 02:31
aosmw and others added 4 commits February 8, 2025 20:40
Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Signed-off-by: Mike Wake <michael.wake@aosgrp.com.au>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
@ewak ewak force-pushed the feature/mw/bt_error_msg_586 branch from 6b2c1af to b43dff0 Compare February 8, 2025 10:27
@ewak ewak force-pushed the feature/mw/bt_error_msg_586 branch from b43dff0 to d423c40 Compare February 8, 2025 11:44
Signed-off-by: Mike Wake <macwake@gmail.com>
@ewak ewak force-pushed the feature/mw/bt_error_msg_586 branch from 151b1c4 to 4504681 Compare February 9, 2025 03:38
ewak added 3 commits February 11, 2025 20:14
Signed-off-by: Mike Wake <macwake@gmail.com>
…ros-navigation#586)

error_code_names - Jazzy and older
error_code_name_prefixes - Kilted and newer

Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Mike Wake <macwake@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants