Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear log directory before / after a build #814

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

dirk-thomas
Copy link
Member

Follow up of #812

When parsing the stdout_stderr.log files to extract warnings it needs to be made that no log files from previous builds are still in the workspace.

@dirk-thomas dirk-thomas self-assigned this Jun 19, 2020
@dirk-thomas
Copy link
Member Author

Since the current regression leads to incorrect results (e.g. http://build.ros2.org/view/Rdev/job/Rdev__rclpy__ubuntu_focal_amd64/4/) I will go ahead and merge this change without waiting for a review. I am happy to address any comments after the fact.

@dirk-thomas dirk-thomas merged commit 3920ae9 into master Jun 19, 2020
@dirk-thomas dirk-thomas deleted the dirk-thomas/delete-log-dir branch June 19, 2020 05:41
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc approval. ✔️

If we had a need to preserve previous build logs we could tar up the log directory before removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants