Add per-project authorization for CI builds #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config field expects a string of XML that is valid when nested within a `<hudson.security.AuthorizationMatrixProperty>`.
|
Please add the new config option to the docs. |
Added the documentation. I could see the logic in moving the block for this option into the CI build files section but I started with it in the general options since it's defined in the base build file. |
dirk-thomas
approved these changes
Feb 5, 2020
| @@ -76,6 +76,13 @@ A set of options which can be used in any build file. | |||
| Note that yaml will turn bare words like ``yes`` into boolean values so it | |||
| is recommended to quote values to avoid interpretation. | |||
|
|
|||
| * ``project_authorization_xml``: an XML blob which will be nested within a | |||
| ``<hudson.security.AuthorizationMatrixProperty>`` in job builds. | |||
| This property is definied for all build files but as of `#737`_ is only | |||
There was a problem hiding this comment.
Suggested change
| This property is definied for all build files but as of `#737`_ is only | |
| This property is defined for all build files but as of `#737`_ is only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify per-job (per-project in Jenkins parlance) XML configuration for access control.
I've added config field
project_authorization_xmlto the base BuildFile class but only wired it through for CI jobs where we currently want it.In order for this configuration to be honored Jenkins Authorization must be configured to use the Project-based Matrix Authorization Strategy whereas the current buildfarm deployment default is Matrix-based security without per-project settings.