Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "remove using the test_depend from binary jobs (#534)" #540

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

mikaelarguedas
Copy link
Contributor

This reverts commit 0ab65b0.

See #539 for details

@mikaelarguedas
Copy link
Contributor Author

As this was released in 2.0.0, we may want to release a new version with this reverted.
Unless we want to wait to have a better resolution to the issue?

@dirk-thomas
Copy link
Member

I am fine with reverting the change. We should add a comment though why we need these test dependencies for future understanding.

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to try and examine the impact of reverting vs maintaining this change to aid in making the revert decision. But there's no doubt it's causing regressions and the impact is wide enough to merit reverting before making that exploration.

@dirk-thomas dirk-thomas merged commit 2e3afa9 into master Apr 26, 2018
@dirk-thomas dirk-thomas deleted the revert_534 branch April 26, 2018 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants