add test dependencies to package build dependencies

[dirk-thomas]

No description provided.

[wjwwood]

Should this be released immediately and for all ROS distros?

[tfoote]

If were're disabling tests. We should remove the dh_auto_test invocation too. And this will mean that we never can run the tests in the debbuild.

[dirk-thomas]

It is necessary for any package using format 2 in the future (since test dependencies won't be available anymore by default). Since the users requested this to possible in all ROS distros it would need to be applied to all. But it doesn't have to be released immediately.

The list of related changed is long (and not even complete yet). It can be rolled out with the other stuff together.

Due to the usage of DCATKIN_SKIP_TESTING=1 which keeps all testing macros but disables them (making them basically no-ops) I would expect no regressions. But there is always the possibility that some weird CMake files of existing packages might break.

[dirk-thomas]

Since the Debian package only allows to specify build and run dependencies and with format 2 the test dependencies are separate from this the package does not know its test dependencies anymore and can therefore not run its tests.

[dirk-thomas]

The travis error seems to be related to code style violations - all in parts which are not touched by this pull request? Locally the tests pass for me though.

[wjwwood]

Fixed in 30f7b61, please rebase.

Apparently, the new version of pep8 from pip is more aggressive, I was able to reproduce by upgrading it.

[dirk-thomas]

I reworked this completely. Instead of disabling tests the test dependencies are now rolled into the build dependencies so that tests can be build as well as run.

[tfoote]

+1

[wjwwood]

+1

[k-okada]

I'm not sure if this is our special case, or general problem, but sometimes on x86 and always on arm, the buildfirm can not find package only included in test_depends
ros-infrastructure/ros_buildfarm#539