-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New message definition for the ToolData #272
Conversation
int8 analog_input_range3 # one of ANALOG_INPUT_RANGE_* | ||
float64 analog_input2 | ||
float64 analog_input3 | ||
float32 tool_voltage_48V |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ROS naming conventions: the V
should be lower case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@gavanderhoorn: Could you approve the PR? I could then open a PR to integrate the related parsing code into the ur_modern_driver |
uint8 TOOL_RUNNING_MODE = 253 | ||
uint8 TOOL_IDLE_MODE = 255 | ||
|
||
uint8 tool_mode # one of TOOL_BOOTLOADER_* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comment should read: # one of TOOL_*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
A comment on this PR: thinking about it a bit, I'm actually not really a fan of adding these kind of messages. I'm rather a fan of having ROS drivers publish messages that are interpretable on their own, instead of needing another bit of information to be able to understand their contents. In this case, I'd rather the I'll still merge it, but I think we should take a good look at how we want to handle these kind of cases in the future. |
@ThomasTimm: fyi. |
This PR contains a new message definition for the ToolData that contains the analog inputs from the tool which where not available so far. The message contains numerical constants so that the user can understand the flags and modes easier.