Add humble to the supported distros #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add in the test here below too for humble industrial_ci/.github/workflows/main.yml Line 67 in 25481e5 |
|
@Briancbn this is working. Can you merge? |
|
@mathias-luedtke please help take a look:) |
|
Also tested it with ros2_canopen which works. |
mathias-luedtke
requested changes
May 15, 2022
|
And please add it in the documentation as well: https://github.com/ros-industrial/industrial_ci/blob/master/doc/index.rst#supported-ros-distributions |
|
Should be good to merge now. |
mathias-luedtke
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should add humble to the supported distros.
I think this will do it but I still need to test.