-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-generate matrix for CI #257
Conversation
7786918
to
23c560b
Compare
@twdragon @knorth55 so this is just a rough draft for now...but you can see how this PR auto-generates the CI matrix for us (ideally for just the active ROS distros.) for both ROS 1 and ROS 2. Right now it isn't skipping galactic (not sure why but I'll debug tomorrow) and also its duplicating rolling...which it should not. Tomorrow I'll add a commit that creates a basic ROS 1 node wrapper we can use as a starting point...so we all can then use the same base library for both ROS 1 and ROS 2. Let me know if you have any questions so far 👍🏼 |
6981ad2
to
5ba431d
Compare
Signed-off-by: Evan Flynn <evan.flynn@apex.ai>
a0f7c9a
to
44eb075
Compare
Signed-off-by: Evan Flynn <evan.flynn@apex.ai>
44eb075
to
cbed40e
Compare
@twdragon @knorth55 so how much of the first ROS 1 node did you guys want me to add here? I figured I would just get it "stood up" and then you guys update it in other PRs. Is that OK with you guys? If yes, then this PR is ready to be merged (I am OK with having the ROS 1 CI job fail for a while while we work on getting it up and running. |
@flynneva thanks for this contribution! Let me study a bit the code to see what should be done to match with the new internal API. I think it could be done |
@twdragon any updates here? Let me know if you have any questions |
@flynneva unfortunately no, I have a lot of tasks for now. But I will not
leave the project, do not worry. I hope to return to it in the middle of
August, after solving some of my tasks emerged now
сб, 15 июл. 2023 г., 18:20 Evan Flynn ***@***.***>:
… @twdragon <https://github.com/twdragon> any updates here? Let me know if
you have any questions
—
Reply to this email directly, view it on GitHub
<#257 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF5WP6FEOUFIRY5Y4BDZ5MLXQK7N7ANCNFSM6AAAAAAZCB4JEU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Superseeded by #294 |
Relates to #255