Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generate matrix for CI #257

Closed
wants to merge 2 commits into from

Conversation

flynneva
Copy link
Collaborator

@flynneva flynneva commented Jun 11, 2023

  • Adds CI support for ROS 2 Iron (by auto-generating CI matrix)
  • Ensure only active ROS distros are added to generated CI matrix
  • Also add ROS 1 CI job (noetic)
  • Add basic ROS 1 node wrapper around base usb_cam library

Relates to #255

@flynneva flynneva changed the base branch from develop to ros2 June 11, 2023 03:26
@flynneva flynneva force-pushed the 255-add-ros1-to-ci branch from 7786918 to 23c560b Compare June 11, 2023 03:28
@flynneva
Copy link
Collaborator Author

flynneva commented Jun 11, 2023

@twdragon @knorth55 so this is just a rough draft for now...but you can see how this PR auto-generates the CI matrix for us (ideally for just the active ROS distros.) for both ROS 1 and ROS 2. Right now it isn't skipping galactic (not sure why but I'll debug tomorrow) and also its duplicating rolling...which it should not.

Tomorrow I'll add a commit that creates a basic ROS 1 node wrapper we can use as a starting point...so we all can then use the same base library for both ROS 1 and ROS 2.

Let me know if you have any questions so far 👍🏼

@flynneva flynneva force-pushed the 255-add-ros1-to-ci branch 7 times, most recently from 6981ad2 to 5ba431d Compare June 11, 2023 17:43
Signed-off-by: Evan Flynn <evan.flynn@apex.ai>
@flynneva flynneva force-pushed the 255-add-ros1-to-ci branch 4 times, most recently from a0f7c9a to 44eb075 Compare June 11, 2023 18:31
Signed-off-by: Evan Flynn <evan.flynn@apex.ai>
@flynneva flynneva force-pushed the 255-add-ros1-to-ci branch from 44eb075 to cbed40e Compare June 11, 2023 18:35
@flynneva
Copy link
Collaborator Author

@twdragon @knorth55 so how much of the first ROS 1 node did you guys want me to add here? I figured I would just get it "stood up" and then you guys update it in other PRs.

Is that OK with you guys? If yes, then this PR is ready to be merged (I am OK with having the ROS 1 CI job fail for a while while we work on getting it up and running.

@twdragon
Copy link
Collaborator

@flynneva thanks for this contribution! Let me study a bit the code to see what should be done to match with the new internal API. I think it could be done

@flynneva
Copy link
Collaborator Author

@twdragon any updates here? Let me know if you have any questions

@twdragon
Copy link
Collaborator

twdragon commented Jul 15, 2023 via email

@flynneva
Copy link
Collaborator Author

Superseeded by #294

@flynneva flynneva closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants