Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated ::set-output #13

Closed
christophfroehlich opened this issue Feb 21, 2024 · 0 comments · Fixed by #53
Closed

Deprecated ::set-output #13

christophfroehlich opened this issue Feb 21, 2024 · 0 comments · Fixed by #53

Comments

@christophfroehlich
Copy link
Contributor

ros2_control_ci/.github/workflows/reusable-update-pre-commit.yml

Line 27 in ec7c2ac

git diff --quiet && echo "::set-output name=changed::false" || echo "::set-output name=changed::true"

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
christophfroehlich added a commit that referenced this issue Apr 23, 2024
@christophfroehlich
Fix #13
1cf119c
@christophfroehlich christophfroehlich linked a pull request Apr 23, 2024 that will close this issue
Updates for noble #53
Merged
@christophfroehlich christophfroehlich mentioned this issue Apr 23, 2024
Merged
christophfroehlich added a commit that referenced this issue Apr 24, 2024
@christophfroehlich @github-actions
Updates for noble (#53)
b7592c8 
* Deactivate ROSDISTRO_INDEX_URL again

* Try to use a bare ubuntu container

* Noble is now supported by setup-ros

* Add container input also for source build and pre-commit

* Cleanup

* Set it for pre-commit

* Fix pre-commit

* Test if this fixes the .git error

* Fix also auto-update

* Fix paths for autoupdate

* Fix paths

* Fix #13

* Use correct var

* Remove double env.path

* Bump version of pre-commit hooks (#58)

Co-authored-by: christophfroehlich <3367244+christophfroehlich@users.noreply.github.com>

* Harden behavior if sudo is installed or not

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: christophfroehlich <3367244+christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates for noble ros-controls/ros2_control_ci
1 participant
@christophfroehlich