Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code #262

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

christophfroehlich
Copy link
Contributor

Deprecations are released on Jazzy and Rolling with their sync within the last days.

Fixes #203

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (db891ef) to head (a4e39f5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   70.12%   70.69%   +0.57%     
==========================================
  Files           8        8              
  Lines         492      488       -4     
  Branches       84       84              
==========================================
  Hits          345      345              
+ Misses         92       88       -4     
  Partials       55       55              
Flag Coverage Δ
unittests 70.69% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/realtime_tools/realtime_box.hpp 85.24% <ø> (ø)
src/realtime_helpers.cpp 41.48% <ø> (+1.69%) ⬆️

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should do this for Jazzy. This might break users code

@christophfroehlich
Copy link
Contributor Author

In principle, I agree :D let @bmagyar decide; I could handle the branching for jazzy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated code
3 participants