-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pasta: set --host-lo-to-ns-lo
; CI: update pasta
#482
Conversation
Regression in AkihiroSuda/passt-mirror@2024_09_06.6b38f07...2024_10_30.ee7d0b6 https://github.com/rootless-containers/rootlesskit/actions/runs/12783037201/job/35633471012
|
Regression in https://passt.top/passt/commit/?id=b4dace8f462b346ae2135af1f8d681a99a849a5f "fwd: Direct inbound spliced forwards to the guest's external address" A minimal reproducer w/o Docker: |
--host-lo-to-ns-lo
; CI: update pasta
Updated PR to exec pasta with This flag seems already deprecated, but any chance to undeprecate it? |
Oops. I would argue that it's a regression for this specific test, but not for the functionality. That is, But anyway:
...that's something that you and probably some users expected to work, so we definitely have to keep it working. From the related discussion I would say that the only reason why it was introduced directly as deprecated is that, eventually, we would like to replace it with a more generic configuration interface (the runtime port forwarding interface I mentioned a couple of times), where one can say "map x to y" in a generic way. But I would suggest that, until then, you can use it, and I'll make a note to find a working alternative for rootlesskit if we ever drop that option (it won't happen any time soon, anyway). |
--host-lo-to-ns-lo
; CI: update pasta--host-lo-to-ns-lo
; CI: update pasta (also fixes gofmt
)
Needed to keep `docker run -p 127.0.0.1:8080:80` functional with passt >= 2024_10_30.ee7d0b6 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
--host-lo-to-ns-lo
; CI: update pasta (also fixes gofmt
)--host-lo-to-ns-lo
; CI: update pasta
No description provided.