Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pasta: set --host-lo-to-ns-lo; CI: update pasta #482

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

AkihiroSuda
Copy link
Member

No description provided.

@AkihiroSuda AkihiroSuda marked this pull request as draft January 15, 2025 06:48
@AkihiroSuda AkihiroSuda changed the title CI: update pasta (2024_12_11.09478d5) CI: update pasta Jan 15, 2025
@AkihiroSuda
Copy link
Member Author

Regression in AkihiroSuda/passt-mirror@2024_09_06.6b38f07...2024_10_30.ee7d0b6

https://github.com/rootless-containers/rootlesskit/actions/runs/12783037201/job/35633471012

Docker integration test: net=pasta, port-driver=implicit

+ docker run -d --name=nginx -p 127.0.0.1:8080:80 nginx:alpine
c97d3321bb3e442209855c85ad2f348b6e9bc98dfda4a1d633c4f70896312abf
+ sleep 2
+ curl -fsSL http://127.0.0.1:8080/
curl: (56) Recv failure: Connection reset by peer

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jan 15, 2025

Regression in https://passt.top/passt/commit/?id=b4dace8f462b346ae2135af1f8d681a99a849a5f

"fwd: Direct inbound spliced forwards to the guest's external address"

A minimal reproducer w/o Docker: rootlesskit --net=pasta --port-driver=implicit nc -l 127.0.0.1 12345 no longer forwards the port 12345

@AkihiroSuda
Copy link
Member Author

@AkihiroSuda AkihiroSuda changed the title CI: update pasta pasta: set --host-lo-to-ns-lo; CI: update pasta Jan 15, 2025
@AkihiroSuda
Copy link
Member Author

Updated PR to exec pasta with --host-lo-to-ns-lo, so as to keep docker run -p 127.0.0.1:8080:80 functional with passt >= 2024_10_30.ee7d0b6

This flag seems already deprecated, but any chance to undeprecate it?
cc @sbrivio-rh 🙏

@sbrivio-rh
Copy link
Contributor

A minimal reproducer w/o Docker: rootlesskit --net=pasta --port-driver=implicit nc -l 127.0.0.1 12345 no longer forwards the port 12345

Oops. I would argue that it's a regression for this specific test, but not for the functionality. That is, nc -l 12345 would still work: it's just binding specifically to loopback inside the container that doesn't expose that port. If you bind to "any" address, it works.

But anyway:

This flag seems already deprecated, but any chance to undeprecate it?

...that's something that you and probably some users expected to work, so we definitely have to keep it working.

From the related discussion I would say that the only reason why it was introduced directly as deprecated is that, eventually, we would like to replace it with a more generic configuration interface (the runtime port forwarding interface I mentioned a couple of times), where one can say "map x to y" in a generic way.

But I would suggest that, until then, you can use it, and I'll make a note to find a working alternative for rootlesskit if we ever drop that option (it won't happen any time soon, anyway).

pkg/network/pasta/pasta.go Outdated Show resolved Hide resolved
pkg/network/pasta/pasta.go Outdated Show resolved Hide resolved
pkg/network/pasta/pasta.go Outdated Show resolved Hide resolved
@AkihiroSuda AkihiroSuda marked this pull request as ready for review January 16, 2025 00:10
@AkihiroSuda AkihiroSuda added this to the v2.3.2 milestone Jan 16, 2025
@sbrivio-rh
Copy link
Contributor

@dgibson

@AkihiroSuda AkihiroSuda changed the title pasta: set --host-lo-to-ns-lo; CI: update pasta pasta: set --host-lo-to-ns-lo; CI: update pasta (also fixes gofmt) Jan 16, 2025
Needed to keep `docker run -p 127.0.0.1:8080:80` functional with
passt >= 2024_10_30.ee7d0b6

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title pasta: set --host-lo-to-ns-lo; CI: update pasta (also fixes gofmt) pasta: set --host-lo-to-ns-lo; CI: update pasta Jan 16, 2025
@AkihiroSuda AkihiroSuda merged commit 7aef506 into rootless-containers:master Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants