Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix rendering of restore mons doc #66

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

travisn
Copy link
Member

@travisn travisn commented Oct 20, 2022

The restore quorum doc had some extra output and also need consistent formatting between the blocks of
output.

My bad for not viewing the rendered output before merging #65.

Copy link
Collaborator

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at the output, I should have checked 😄

Copy link
Collaborator

@subhamkrai subhamkrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to add a line here too, to press enter to continue ?
https://github.com/rook/kubectl-rook-ceph/pull/66/files#diff-435fa82258cbc13d1341a8b3083eb5147d9be44afa7d12cb6a733352c11a38b2R133

I see we have added earlier

The restore quorum doc had some extra output and also
needs consistent formatting between the blocks of
output.

Signed-off-by: Travis Nielsen <tnielsen@redhat.com>
@travisn travisn merged commit 620d1c9 into rook:master Oct 20, 2022
@travisn travisn deleted the restore-doc branch October 20, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants