Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a software_version: keyword argument to Target#initialize and Mixins::HasTargets::ClassMethods#target #148

Closed
postmodern opened this issue Aug 6, 2024 · 1 comment
Closed

Add a software_version: keyword argument to Target#initialize and Mixins::HasTargets::ClassMethods#target #148

postmodern opened this issue Aug 6, 2024 · 1 comment
Assignees
@postmodern
Labels
enhancement Enhancement to existing code targets-api Targets API
Milestone
1.2.0

Comments

@postmodern
Copy link
Member

Add a software_version: keyword argument instead of version: for consistency. Still support version: for backwards compatibility.

Also, rename the version: keyword argument in Mixins::HasTargets#select_target to software_version:, since that method is part of the internal/semi-public API that users are not supposed to directly call.
@postmodern postmodern added enhancement Enhancement to existing code targets-api Targets API labels Aug 6, 2024
@postmodern postmodern added this to the 1.2.0 milestone Aug 6, 2024
@postmodern postmodern self-assigned this Aug 6, 2024
postmodern added a commit that referenced this issue Aug 6, 2024
@postmodern
Use software_version instead of just version for consistency (closes
909a5c2 
 #148).
@postmodern
Copy link
Member Author

Implemented by 909a5c2.

postmodern added a commit that referenced this issue Aug 7, 2024
@postmodern
Use software_version instead of just version for consistency (closes
21166d1 
 #148).
postmodern added a commit that referenced this issue Aug 7, 2024
@postmodern
Renamed run --target-version to run --target-software-version (#148…
e034081 
…).
postmodern added a commit that referenced this issue Aug 7, 2024
@postmodern
Use software_version instead of just version for consistency (closes
6a8a8d2 
 #148).
postmodern added a commit that referenced this issue Aug 7, 2024
@postmodern
Renamed run --target-version to run --target-software-version (#148…
6afe190 
…).
postmodern added a commit that referenced this issue Dec 9, 2024
@postmodern
Use software_version instead of just version for consistency (closes
d486a17 
 #148).
postmodern added a commit that referenced this issue Dec 9, 2024
@postmodern
Renamed run --target-version to run --target-software-version (#148…
956f9e3 
…).
postmodern added a commit that referenced this issue Dec 9, 2024
@postmodern
Use software_version instead of just version for consistency (closes
415b061 
 #148).
postmodern added a commit that referenced this issue Dec 9, 2024
@postmodern
Renamed run --target-version to run --target-software-version (#148…
92c8d80 
…).
postmodern added a commit that referenced this issue Dec 9, 2024
@postmodern
Use software_version instead of just version for consistency (closes
e991a98 
 #148).
postmodern added a commit that referenced this issue Dec 9, 2024
@postmodern
Renamed run --target-version to run --target-software-version (#148…
b9e6c4f 
…).
postmodern added a commit that referenced this issue Dec 10, 2024
@postmodern
Use software_version instead of just version for consistency (closes
3de9eb1 
 #148).
postmodern added a commit that referenced this issue Dec 10, 2024
@postmodern
Renamed run --target-version to run --target-software-version (#148…
50c4450 
…).
postmodern added a commit that referenced this issue Dec 10, 2024
@postmodern
Use software_version instead of just version for consistency (closes
72213ec 
 #148).
postmodern added a commit that referenced this issue Dec 10, 2024
@postmodern
Renamed run --target-version to run --target-software-version (#148…
a90031a 
…).
postmodern added a commit that referenced this issue Dec 13, 2024
@postmodern
Use software_version instead of just version for consistency (closes
a1cd71c 
 #148).
postmodern added a commit that referenced this issue Dec 13, 2024
@postmodern
Renamed run --target-version to run --target-software-version (#148…
23b7628 
…).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@postmodern postmodern

Labels
enhancement Enhancement to existing code targets-api Targets API
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@postmodern