Skip to content

Commit

Permalink
Add node version to examples and jobs
Browse files Browse the repository at this point in the history
  • Loading branch information
roni-castro committed Jan 16, 2020
1 parent 073689c commit f9651d3
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
2 changes: 2 additions & 0 deletions src/examples/full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ usage:
# Build the iOS app in release mode and do not run tests
- rn/ios_build:
name: build_ios_release
node_version: '10'
project_path: ios/Example.xcodeproj
device: "iPhone X"
build_configuration: Release
Expand All @@ -98,6 +99,7 @@ usage:

# Build and test the iOS app in release mode
- rn/ios_build_and_test:
node_version: '10'
project_path: "ios/Example.xcodeproj"
device: "iPhone X"
build_configuration: "Release"
Expand Down
8 changes: 7 additions & 1 deletion src/jobs/android_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,17 @@ parameters:
description: A custom command to run right after yarn install.
type: string
default: ""
# For macos executor
node_version:
description: The version of Node to use. This can be either a major version ("8"), a major and minor ("8.4"), or a fully qualified version ("8.4.1").
type: string
default: 'latest'

steps:
- attach_workspace:
at: <<parameters.workspace_root>>
- setup_macos_executor
- setup_macos_executor:
node_version: <<parameters.node_version>>
- yarn_install
- when:
condition: <<parameters.on_after_initialize>>
Expand Down
8 changes: 7 additions & 1 deletion src/jobs/ios_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ parameters:
description: A custom command to run right after yarn install.
type: string
default: ""
# For macos executor
node_version:
description: The version of Node to use. This can be either a major version ("8"), a major and minor ("8.4"), or a fully qualified version ("8.4.1").
type: string
default: 'latest'

steps:
- when:
Expand All @@ -59,7 +64,8 @@ steps:
steps:
- attach_workspace:
at: <<parameters.workspace_root>>
- setup_macos_executor
- setup_macos_executor:
node_version: <<parameters.node_version>>
- yarn_install
- when:
condition: <<parameters.on_after_initialize>>
Expand Down

0 comments on commit f9651d3

Please sign in to comment.