Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly serialize f32 #81

Merged
merged 1 commit into from
Jan 21, 2018
Merged

Directly serialize f32 #81

merged 1 commit into from
Jan 21, 2018

Conversation

pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Jan 21, 2018

Currently f32 is serialized by converting to f64 first. This results in some numbers printed with many decimal places that do not convey information. (A f32 can represent about 6 decimal places)

Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

bors bot added a commit that referenced this pull request Jan 21, 2018
81: Directly serialize f32 r=torkleyy a=pyfisch

Currently f32 is serialized by converting to f64 first. [This results in some numbers printed with many decimal places that do not convey information](https://play.rust-lang.org/?gist=2d8e4ab9d5d8fe689fdb6490bb4721c5&version=stable). (A f32 can represent about 6 decimal places)
@bors
Copy link
Contributor

bors bot commented Jan 21, 2018

Build succeeded

@bors bors bot merged commit 1261e65 into ron-rs:master Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants