Fixed serialization for floating point values less than EPSILON. #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found why the tests are failing in an unrelated way - for some reason |
juntyr
reviewed
Mar 31, 2022
|
Thanks for opening the issue @KirbyER! Could you rebase your branch and add the following line (or a better description) to the bottom of the unreleased section of the CHANGELOG: Thanks again for catching this bug and finding a fix! |
|
Sorry, got pulled away yesterday between opening the issue and updating the changelog. Done now. Thanks for sorting out the testing failure so quickly! |
torkleyy
pushed a commit
to torkleyy/ron
that referenced
this pull request
Jun 6, 2022
…-rs#372) Co-authored-by: KirbyER <7432155-KirbyER@users.noreply.gitlab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
EPSILONis defined as the difference between 1 and the next highest value, and values close to zero have higher precision, very small values were serialized with an extra ".0" e.g. "0.00000000000000005.0". These values then can't be properly deserialized. This fix compares the fractional part of the float to 0.0 instead of usingEPSILON.Fixes #374.
CHANGELOG.md