Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #289 enumerate_arrays comments #344

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Fix #289 enumerate_arrays comments #344

merged 1 commit into from
Nov 22, 2021

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Nov 22, 2021 •
edited
Loading

Fixes #289 and an associated TODO by moving the array index comments in front of the items using /*[i]*/.

  • I've included my change in CHANGELOG.md

@juntyr
Copy link
Member Author

juntyr commented Nov 22, 2021

?r @torkleyy

torkleyy
torkleyy approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good fix for the issue - but personally I find the comments too "noisy".

Still seems like an improvement though! :shipit:

@juntyr
Copy link
Member Author

juntyr commented Nov 22, 2021

I think that's a good fix for the issue - but personally I find the comments too "noisy".

I agree with that. I just saw the issue and thought it made a nice quick break from uni work.

Still seems like an improvement though! :shipit:

Thanks!

@juntyr juntyr merged commit ed3577c into ron-rs:master Nov 22, 2021
@juntyr juntyr deleted the enumerate-arrays-fix branch November 22, 2021 19:20
@juntyr juntyr mentioned this pull request Dec 18, 2021
Closed
torkleyy pushed a commit to torkleyy/ron that referenced this pull request Jun 6, 2022
@juntyr @torkleyy
Merge pull request ron-rs#344 from MomoLangenstein/enumerate-arrays-fix
7a7bc30 
Fix ron-rs#289 enumerate_arrays comments
@torkleyy torkleyy mentioned this pull request Jun 6, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkleyy torkleyy torkleyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enumerate_arrays doesn't annotate last item in array and comments are badly placed
2 participants
@juntyr @torkleyy