This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_fs): Allow to ignore patterns to symbolic links (symlinks) #4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
1bd0ed2 to
2d3fbbd
Compare
|
I expanded the test case. |
ematipico
suggested changes
Feb 14, 2023
Merged
|
@ematipico I documented the code and updated the test, now that #4158 was merged. Please let me know if this is sufficient. |
ematipico
approved these changes
Mar 5, 2023
crates/rome_cli/tests/snapshots/main_commands_check/fs_files_ignore_symlink.snap
Outdated
Show resolved
Hide resolved
ematipico
pushed a commit
that referenced
this pull request
Mar 10, 2023
…4166) * fix(rome_fs): Allow to ignore patterns to symbolic links (symlinks) * refactor: file_name might be None * document the origin_path argument * update test * fix formatting * update test
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Rome could not ignore patterns to symbolic links (symlinks) during traversal.
Example - A rome.json configuration file with the
files.ignoreoption{ "files": { "ignore": [ "symlink/**/*.ts", ] } }This implementation works for simple use cases. It does not cover symbolic links inside of symbolic links. For performance reasons, only the last resolved symbolic link is preserved and not the entire path resolution tree.
Related