This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): Suggested fix for Conditional Assignment #3771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
approved these changes
Nov 17, 2022
leops
approved these changes
Nov 17, 2022
| if let JsAssignmentOperator::Assign = op { | ||
| let mut mutation = ctx.root().begin(); | ||
| let token = state.operator_token().ok()?; | ||
| mutation.replace_token(token, make::token(JsSyntaxKind::EQ3)); |
There was a problem hiding this comment.
This mutation leaves the JsAssignmentExpression node in place but replaces its operator token with ===. It won't cause any issue with linting right now since the only thing we do with the resulting syntax tree is to print it to a string, and the rule being flagged as MaybeIncorrect means it won't be included in the "Fix All" action. We don't even detect the resulting syntax tree as invalid right now since we don't check if the kind of individual tokens matches the definition for the surrounding AST node, I just thought I should flag this as a potential future issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Suggested fix for Conditional Assignment. (Followup from #3750 (review))
Test Plan
Added/Updated tests.