Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

Commit

Permalink
address PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
leops committed Nov 9, 2022
1 parent 3f537f4 commit e1039ae
Show file tree
Hide file tree
Showing 3 changed files with 68 additions and 2 deletions.
4 changes: 2 additions & 2 deletions crates/rome_js_analyze/src/react.rs
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,14 @@ pub(crate) enum ReactLibrary {
}

impl ReactLibrary {
fn import_name(self) -> &'static str {
const fn import_name(self) -> &'static str {
match self {
ReactLibrary::React => "react",
ReactLibrary::ReactDOM => "react-dom",
}
}

fn global_name(self) -> &'static str {
const fn global_name(self) -> &'static str {
match self {
ReactLibrary::React => "React",
ReactLibrary::ReactDOM => "ReactDOM",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
function render() { }
const ReactDOM = { render };

const a = ReactDOM.render(<div />, document.body);
const foo = bar && ReactDOM.render(<div />, document.body);
const foo = bar ? ReactDOM.render(<div />, document.body) : null
const foo = () => ReactDOM.render(<div />, document.body);
const foo = {
react: ReactDOM.render(<div />, document.body)
};
let lorem;
lorem = ReactDOM.render(<div />, document.body);
function render1() {
return ReactDOM.render(<div />, document.body)
}

const a = render(<div />, document.body);
const foo = bar && render(<div />, document.body);
const foo = bar ? render(<div />, document.body) : null
const foo = () => render(<div />, document.body);
const foo = {
react: render(<div />, document.body)
};
let lorem;
lorem = render(<div />, document.body);
function render1() {
return render(<div />, document.body)
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
source: crates/rome_js_analyze/tests/spec_tests.rs
expression: validLocal.tsx
---
# Input
```js
function render() { }
const ReactDOM = { render };

const a = ReactDOM.render(<div />, document.body);
const foo = bar && ReactDOM.render(<div />, document.body);
const foo = bar ? ReactDOM.render(<div />, document.body) : null
const foo = () => ReactDOM.render(<div />, document.body);
const foo = {
react: ReactDOM.render(<div />, document.body)
};
let lorem;
lorem = ReactDOM.render(<div />, document.body);
function render1() {
return ReactDOM.render(<div />, document.body)
}

const a = render(<div />, document.body);
const foo = bar && render(<div />, document.body);
const foo = bar ? render(<div />, document.body) : null
const foo = () => render(<div />, document.body);
const foo = {
react: render(<div />, document.body)
};
let lorem;
lorem = render(<div />, document.body);
function render1() {
return render(<div />, document.body)
}

```


0 comments on commit e1039ae

Please sign in to comment.