fix: apply chmod at pkg creation time (#3800)

Fixes #3799
rome · Nov 21, 2022 · bfe0212 · bfe0212
1 parent c39ee57
commit bfe0212
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/npm/rome/scripts/generate-packages.mjs b/npm/rome/scripts/generate-packages.mjs
@@ -44,6 +44,7 @@ function generateNativePackage(platform, arch) {
 
 	console.log(`Copy binary ${binaryTarget}`);
 	fs.copyFileSync(binarySource, binaryTarget);
+	fs.chmodSync(binaryTarget, 0o755);
 }
 
 function updateWasmPackage(target) {

diff --git a/npm/rome/scripts/postinstall.js b/npm/rome/scripts/postinstall.js
@@ -25,17 +25,6 @@ if (binName) {
 			`The Rome CLI postinstall script failed to resolve the binary file "${binName}". Running Rome from the npm package will probably not work correctly.`,
 		);
 	}
-
-	if (binPath) {
-		try {
-			require("fs").chmodSync(binPath, 0o755);
-		} catch {
-			console.warn(
-				"The Rome CLI postinstall script failed to set execution permissions to the native binary. " +
-					"Running Rome from the npm package will probably not work correctly.",
-			);
-		}
-	}
 } else {
 	console.warn(
 		"The Rome CLI package doesn't ship with prebuilt binaries for your platform yet. " +