Create/Edit Article view #24
Conversation
| @@ -21,18 +21,39 @@ | |||
| (cstr/join ", " v) | |||
| v))])]) | |||
|
|
|||
| (rum/defc InputFieldContainer [value & children] | |||
| (apply vector :fieldset.form-group children)) | |||
There was a problem hiding this comment.
do not generate Hiccup forms programatically
| (defn TagInputFieldContainer [data errors key] | ||
| (fn [value & children] | ||
| (let [{:keys [tagList]} @data] | ||
| (apply vector :fieldset.form-group children |
There was a problem hiding this comment.
do not generate Hiccup forms programatically
| :on-blur on-blur | ||
| :on-focus on-focus} | ||
| events)] | ||
| (input-container |
There was a problem hiding this comment.
if you need different container elements this most likely should be two separate components instead
| :tag {:placeholder "Enter tags" | ||
| :container TagInputFieldContainer | ||
| :events {:on-key-down | ||
| (fn [data errors key] |
There was a problem hiding this comment.
not sure what this code is doing
There was a problem hiding this comment.
It is trying to modify the key down behaviour:
-
to allow the creation of tags by pressing enter, then clear the input field.
-
Tags will be stored in a virtual form property named
tagListwhich is used for actually sending over to the server.
| @@ -22,3 +22,29 @@ | |||
|
|
|||
| (defmethod control :update [_ [id transform data] state] | |||
| {:state (merge state (transform data))}) | |||
|
|
|||
| (defmethod control :save [_ [{:keys [title description body tagList]} token id] state] | |||
| (let [http-params (if id | |||
There was a problem hiding this comment.
it would be better to make conditional assignments inside of the :http map directly, without creating intermediate values and merging them together
| data (atom data-init) | ||
| errors (atom errors-init) | ||
| fields-init (->> fields |
There was a problem hiding this comment.
This code looks complex. Also I think it should be gone since :container and :events config fields is a bit overgeneralization for a single component like InputField.
There was a problem hiding this comment.
Since form data and form errors are not exposed outside of the form mixin for altering, there is no way to set a new form property for tags. So I come up with this hacky solution by exposing form data form errors atoms to :container and :events for altering, which should make very minimal impact on the form state while still keeping it general enough for other situations. I know it doesn't sound like a good idea, but I think it serves the purpose for now.
No description provided.