feat(node-resolve): dedupe by package name

packages/node-resolve/src/index.js

@@ -136,6 +136,14 @@ function resolveImportSpecifiers(importSpecifierList, resolveOptions) {
   return p;
 }
 
+function getPackageName(id) {
+  const split = id.split('/');
+  if (split[0][0] === '@') {
+    return `${split[0]}/${split[1]}`;
+  }
+  return split[0];
+}
+
 export default function nodeResolve(options = {}) {
   const mainFields = getMainFields(options);
   const useBrowserOverrides = mainFields.indexOf('browser') !== -1;
@@ -165,7 +173,9 @@ export default function nodeResolve(options = {}) {
   const idToPackageInfo = new Map();
 
   const shouldDedupe =
-    typeof dedupe === 'function' ? dedupe : (importee) => dedupe.includes(importee);
+    typeof dedupe === 'function'
+      ? dedupe
+      : (importee) => dedupe.includes(importee) || dedupe.includes(getPackageName(importee));
 
   function getCachedPackageInfo(pkg, pkgPath) {
     if (packageInfoCache.has(pkgPath)) {

packages/node-resolve/test/dedupe.js

@@ -23,6 +23,34 @@ test('single module version is bundled if dedupe is set', async (t) => {
   t.snapshot(module.exports);
 });
 
+test('dedupes deep imports by package name if dedupe is set', async (t) => {
+  const bundle = await rollup({
+    input: 'react-app-deep-import.js',
+    plugins: [
+      nodeResolve({
+        dedupe: ['react']
+      })
+    ]
+  });
+  const { module } = await testBundle(t, bundle);
+
+  t.snapshot(module.exports);
+});
+
+test('dedupes scoped deep imports by package name if dedupe is set', async (t) => {
+  const bundle = await rollup({
+    input: 'scoped-deep-import.js',
+    plugins: [
+      nodeResolve({
+        dedupe: ['@scoped/deduped']
+      })
+    ]
+  });
+  const { module } = await testBundle(t, bundle);
+
+  t.snapshot(module.exports);
+});
+
 test('single module version is bundled if dedupe is set as a function', async (t) => {
   const bundle = await rollup({
     input: 'react-app.js',

packages/node-resolve/test/fixtures/react-app-deep-import.js

@@ -0,0 +1,4 @@
+import React from 'react/deep.js';
+import ReactConsumer from 'react-consumer/deep.js';
+
+export { React, ReactConsumer };

packages/node-resolve/test/fixtures/scoped-deep-import.js

@@ -0,0 +1,4 @@
+import ScopedDeduped from '@scoped/deduped/deep.js';
+import ScopedDedupedConsumer from 'scoped-deduped-consumer';
+
+export { ScopedDeduped, ScopedDedupedConsumer };

packages/node-resolve/test/snapshots/dedupe.js.md

@@ -4,6 +4,24 @@ The actual snapshot is saved in `dedupe.js.snap`.
 
 Generated by [AVA](https://ava.li).
 
+## dedupes deep imports by package name if dedupe is set
+
+> Snapshot 1
+
+    {
+      React: 'react/deep.js:root',
+      ReactConsumer: 'react-consumer:react/deep.js:root',
+    }
+
+## dedupes scoped deep imports by package name if dedupe is set
+
+> Snapshot 1
+
+    {
+      ScopedDeduped: 'scoped-deduped:root',
+      ScopedDedupedConsumer: 'scoped-deduped-consumer:scoped-deduped:root',
+    }
+
 ## multiple module versions are bundled if dedupe is not set
 
 > Snapshot 1