Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias: add missing readonly to internal function #680

Merged
merged 2 commits into from
Dec 2, 2020
Merged

alias: add missing readonly to internal function #680

merged 2 commits into from
Dec 2, 2020

Conversation

benmccann
Copy link
Contributor

Rollup Plugin Name: alias

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: #679

Description

entries is specified as readonly here:

entries?: readonly Alias[] | { [find: string]: string };

This change makes the implementation readonly to match the type definition. TypeScript 4 has stricter checks for readonly and will eventually require this change.

@shellscape shellscape merged commit c816a5c into rollup:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants