Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrading to rc5 #45

Merged
merged 2 commits into from
Jun 27, 2023
Merged

upgrading to rc5 #45

merged 2 commits into from
Jun 27, 2023

Conversation

gupadhyaya
Copy link
Member

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@gupadhyaya gupadhyaya enabled auto-merge June 27, 2023 15:14
nashqueue
nashqueue previously approved these changes Jun 27, 2023
View reviewed changes
tuxcanfly
tuxcanfly requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs --gateway.deprecated-endpoints in entrypoint.sh:

celestia bridge start \
  --node.store /bridge --gateway \
  --core.ip 127.0.0.1 \
  --keyring.accname validator

tuxcanfly
tuxcanfly approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@gupadhyaya gupadhyaya merged commit f7362d0 into main Jun 27, 2023
@gupadhyaya gupadhyaya deleted the rc5-upgrade branch June 27, 2023 16:59
tuxcanfly
tuxcanfly reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to log the auth token so that the client can use it by copying from the logs. It's not perfect but the best stopgap solution I can think of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxcanfly tuxcanfly tuxcanfly approved these changes

@Manav-Aggarwal Manav-Aggarwal Manav-Aggarwal approved these changes

@MSevey MSevey Awaiting requested review from MSevey

@nashqueue nashqueue Awaiting requested review from nashqueue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gupadhyaya @tuxcanfly @Manav-Aggarwal @nashqueue