Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): transform export named declaration #2264

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

underfin
Copy link
Contributor

Description

@underfin underfin force-pushed the 09-19-chore_using_plugin_emit_html branch from 914e086 to eafb5d3 Compare September 20, 2024 07:11
@underfin underfin force-pushed the 09-19-feat_app_transform_export_named_declaration branch from a0cc4bf to 33ed67a Compare September 20, 2024 07:11
@underfin underfin force-pushed the 09-19-chore_using_plugin_emit_html branch from eafb5d3 to 92e1f06 Compare September 20, 2024 07:13
@underfin underfin force-pushed the 09-19-feat_app_transform_export_named_declaration branch from 33ed67a to c2b1841 Compare September 20, 2024 07:13
Copy link

github-actions bot commented Sep 20, 2024

Benchmarks Rust

  • target: hmr-poc(bd2e92f)
  • pr: 09-19-feat_app_transform_export_named_declaration(7b01dea)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     54.2±0.80ms        ? ?/sec    1.01     54.6±1.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     76.6±0.89ms        ? ?/sec    1.01     77.3±0.95ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     94.2±1.35ms        ? ?/sec    1.03     96.8±1.55ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     63.7±0.83ms        ? ?/sec    1.00     62.6±0.57ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    101.2±1.02ms        ? ?/sec    1.01    102.2±0.88ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.02    184.7±7.13ms        ? ?/sec    1.00    180.5±3.07ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00   227.3±10.05ms        ? ?/sec    1.00    227.2±6.04ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    117.6±2.32ms        ? ?/sec    1.00    118.1±1.09ms        ? ?/sec
bundle/bundle@threejs                                               1.00     32.9±0.91ms        ? ?/sec    1.08     35.4±3.66ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     76.2±2.52ms        ? ?/sec    1.01     77.0±2.39ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     94.5±2.00ms        ? ?/sec    1.03     97.5±4.85ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     42.9±0.32ms        ? ?/sec    1.04     44.5±0.62ms        ? ?/sec
bundle/bundle@threejs10x                                            1.02    354.1±2.45ms        ? ?/sec    1.00    348.7±3.20ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    961.2±6.42ms        ? ?/sec    1.01    967.1±6.04ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1224.6±8.46ms        ? ?/sec    1.02  1247.8±10.85ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01    421.6±3.11ms        ? ?/sec    1.00    417.6±2.54ms        ? ?/sec
remapping/remapping                                                 1.02     33.2±0.21ms        ? ?/sec    1.00     32.8±0.16ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     84.2±0.88ms        ? ?/sec    1.00     83.4±1.21ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     81.8±0.94ms        ? ?/sec    1.00     81.6±0.66ms        ? ?/sec
scan/scan@threejs                                                   1.00     25.1±0.21ms        ? ?/sec    1.01     25.3±0.95ms        ? ?/sec
scan/scan@threejs10x                                                1.01    257.3±1.79ms        ? ?/sec    1.00    255.8±1.88ms        ? ?/sec

Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #2264 will improve performances by 8.16%

Comparing 09-19-feat_app_transform_export_named_declaration (7b01dea) with main (ff62f77)

Summary

⚡ 4 improvements
✅ 17 untouched benchmarks

Benchmarks breakdown

Benchmark main 09-19-feat_app_transform_export_named_declaration Change
bundle@multi-duplicated-top-level-symbol 261.9 ms 242.2 ms +8.16%
bundle@multi-duplicated-top-level-symbol-minify 348.4 ms 326 ms +6.87%
bundle@multi-duplicated-top-level-symbol-minify-sourcemap 452.1 ms 430.1 ms +5.11%
bundle@multi-duplicated-top-level-symbol-sourcemap 309.4 ms 290.4 ms +6.54%

Base automatically changed from 09-19-chore_using_plugin_emit_html to hmr-poc September 20, 2024 09:02
@underfin underfin force-pushed the 09-19-feat_app_transform_export_named_declaration branch from c2b1841 to 146181f Compare September 20, 2024 09:04
@underfin underfin marked this pull request as ready for review September 23, 2024 02:16
@underfin underfin merged commit 2de470a into hmr-poc Sep 23, 2024
20 checks passed
@underfin underfin deleted the 09-19-feat_app_transform_export_named_declaration branch September 23, 2024 02:17
underfin added a commit that referenced this pull request Nov 5, 2024
<!-- Thank you for contributing! -->

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant