-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: resolve error printed as debug message #2033
Labels
Comments
Boshen
added
bug
Something isn't working
needs-triage
good first issue
Good for newcomers
labels
Aug 21, 2024
I will try to improve this diagnostic and investigate whether it can be aligned with |
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 22, 2024
<!-- Thank you for contributing! --> ### Description 1. Part of #2033 <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 22, 2024
…s` (#2036) <!-- Thank you for contributing! --> ### Description 1. try #2033 you will receive ![image](https://github.com/user-attachments/assets/f85f4bce-f9eb-489c-8b22-9e800106313c) This is because when there is a none recoverable error occurred in `fetch_all_modules`, the function will directly return https://github.com/rolldown/rolldown/blob/8e0cb613e4dd50b5f70a4a648ad72d243b80a432/crates/rolldown/src/module_loader/module_loader.rs#L286-L288 Then all the pending task will fail to send `Msg` since the channel is closed. Then the `expect` will trigger a panic, https://github.com/rolldown/rolldown/blob/8e0cb613e4dd50b5f70a4a648ad72d243b80a432/crates/rolldown/src/module_loader/module_task.rs#L60-L62 2. This pr will wait for all tasks to be finished when meets a `Msg::Panic` <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 28, 2024
<!-- Thank you for contributing! --> ### Description closes #2033 <img width="814" alt="image" src="https://github.com/user-attachments/assets/7358884a-1283-434a-a4de-c2a5b1a1f810"> <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 28, 2024
<!-- Thank you for contributing! --> ### Description 1. follow up of #2033 <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction link or steps
I'm testing Rolldown in https://github.com/oxc-project/monitor-oxc/tree/rolldown
It's currently producing debug error message for resolve errors. The process also hangs.
What is expected?
Nicer error messages. No hang.
What is actually happening?
rolldown/crates/rolldown/src/types/module_factory.rs
Lines 152 to 155 in 4ca169c
System Info
Any additional comments?
No response
The text was updated successfully, but these errors were encountered: