Fix URL scrubbing and change to a functional object #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f7bf4b to
287c950
Compare
After one scrubbing refactor we starting not passing the scrubing configuration to the URL scrubber. This is fixed with this PR. Also, since params scrubbers was designed as a functional object, URL scrubber is not also a functional object without state. Just to maintain the style for them. Some tests have been added to the scrubbers and the request data extractor module
287c950 to
398a118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After one scrubbing refactor we starting not passing the scrubing
configuration to the URL scrubber. This is fixed with this PR.
Also, since params scrubbers was designed as a functional object, URL
scrubber is not also a functional object without state. Just to maintain
the style for them.
Some tests have been added to the scrubbers and the request data
extractor module