Rollbar js instrumentation #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 9, 2016 12:05
Users can now use the gem to configure the Rollbar JS notifier using the
same initializer.
The gem will inject the Rollbar JS snippet and the configuration to the
returned response.
In order to configure the Rollbar.js using the gem, users can follo the
next:
js_config = {
accessToken: ""POST_CLIENT_ITEM_ACCESS_TOKEN",
captureUncaught: true,
payload: {
environment: "production"
}
}
Rollbar.configure do |config|
# common gem configuration
config.js_enabled = true
config.js_options = js_config
end
The options passed to `#js_options=` are the same than the used for the
Rollbar JS notifier.
It seems we don't need it anymore
|
👍 Nice! |
added 2 commits
February 9, 2016 18:45
df6b0e8 to
de709b7
Compare
de709b7 to
ae7e2b0
Compare
added 2 commits
February 10, 2016 11:25
To prevent conflicts with customers already using Rollbar.js.
jondeandres
added a commit
that referenced
this pull request
Feb 10, 2016
Rollbar js instrumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now use the gem to configure the Rollbar JS notifier using the
same initializer.
The gem will inject the Rollbar JS snippet and the configuration to the
returned response.
In order to configure the Rollbar.js using the gem, users can follow the
next:
The options passed to
#js_options=are the same than the used for theRollbar JS notifier.