Reset the notifier when we use Rollbar.preconfigure #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix the problem we had with gems using `Thread.new` before our
railtie is loaded.
The order to reproduce the bug was:
1 Load Rollbar gem and the Thread monkey patch
2 Rollbar.configure is executed
3 Another gem is loaded and executes Thread.new
3.1 This sets Rollbar.notifier to the current configuration
4 Our railtie is loaded
4.1 The railtie uses preconfigure that changes Rollbar.configuration
4.2 Because we already have a Rollbar.notifier, the new configuration
is not propagated
So now, on `Rollbar.preconfigure` we reset the notifier, so for next
time it's used it will take the last configuration, included the railtie one.
|
👍 |
jondeandres
added a commit
that referenced
this pull request
Feb 4, 2016
Reset the notifier when we use Rollbar.preconfigure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the problem we had with gems using
Thread.newbefore ourrailtie is loaded.
The order to reproduce the bug was:
Load Rollbar gem and the Thread monkey patch
Rollbar.configure is executed
Another gem is loaded and executes Thread.new
3.1 This sets Rollbar.notifier to the current configuration
Our railtie is loaded
4.1 The railtie uses preconfigure that changes Rollbar.configuration
4.2 Because we already have a Rollbar.notifier, the new configuration
is not propagated
So now, on
Rollbar.preconfigurewe reset the notifier, so for nexttime it's used it will take the last configuration, included the railtie one.