Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore exception cause when it's not another exception #357

Merged

Conversation

pedro
Copy link
Contributor

@pedro pedro commented Dec 10, 2015

Custom error classes might define #cause as a string or similar, which would in turn result in an internal Rollbar error.

custom error classes might define #cause as a string or similar,
which would in turn result in an internal Rollbar error.
@jondeandres
Copy link
Contributor

@pedro do you have this error using third party libraries? the problem is with some custom exceptions of your own?

I remember we had a problem with another library that defined its own #cause method, but upgrading the library resolved the problem.

Can you give us those details?

Thanks

@pedro
Copy link
Contributor Author

pedro commented Dec 10, 2015

Hey! For sure, it is actually a private library, so we'll probably end up changing the method name.

But seeing that Ruby didn't give us any warning when we defined that method, and that debugging this in Rollbar took quite some time, I figured it might be worth being extra cautious here. Searching in Github this method doesn't seem all uncommon (wish there was a way to skip duplicates heh).

jondeandres added a commit that referenced this pull request Dec 18, 2015
Ignore exception cause when it's not another exception
@jondeandres jondeandres merged commit f49d496 into rollbar:master Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants