Delayed job integration fix #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: previous Rollbar DelayedJob plugin used Worker Lifecycle directly to register the around hook. DelayedJob now clears and reinitializes the Lifecycle object upon Worker initializations. This means that commands like `rake jobs:work` will first register Rollbar hook, then initialize Worker which will clear the hook. Solution: use the new plugins system to allow Worker to setup its Lifecycle object and register all plugins when it needs to.
jondeandres
added a commit
that referenced
this pull request
Dec 9, 2015
Delayed job integration fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #350.