Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove better errors hook #313

Merged
merged 1 commit into from
Oct 5, 2015
Merged

Conversation

jondeandres
Copy link
Contributor

We have our own middleware reporting errors to the API. Monkey patching
better_errors in the practice the behavior is just reporting the errors
twice: one by our middleware and another one by better_errors.

Beside this, depending on the better_errors version we have two
different behaviors:

  • versions < 2.0: the error is reported twice
  • versions >= 2.0: we report one error by our middleware and a 'Empty message' error cause the exception managed by better_errors doesn't inherit Exception and it's a custom object by better_errors.

I'm not sure why we had this monkey patch but seems it's not useful and
in any scenario is becoming finally in two reports by exception.

We have our own middleare reporting errors to the API. Monkey patching
better_errors in the practice the behavior is just reporting the errors
twice: one by our middleware and another one by better_errors.

Beside this, depending on the better_errors version we have two
different behaviors:

- versions < 2.0: the error is reported twice
- versions >= 2.0: we report one error by our middleware and a 'Empty
- message' error cause the exception managed by better_errors doesn't
- inherit `Exception` and it's a custom object by better_errors.

I'm not sure why we had this monkey patch but seems it's not useful and
in any scenario is becoming finally in two reports by exception.
@jondeandres jondeandres force-pushed the fix-better-errors-integration branch from 31fd732 to 6cfac42 Compare October 1, 2015 16:17
@coryvirok
Copy link
Contributor

Makes sense. Will this cause any users to need to modify their code to continue getting Rollbar errors reported? And is this change backward compatible with people's current install of rollbar-gem?

@jondeandres
Copy link
Contributor Author

@coryvirok no, users that have better_errors installed just will see their errors, in development, are sent just once. now we are sending them twice.

jondeandres added a commit that referenced this pull request Oct 5, 2015
@jondeandres jondeandres merged commit 6f5f38d into master Oct 5, 2015
@waltjones waltjones deleted the fix-better-errors-integration branch June 27, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants