Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send nearest backtrace entry on failsafe messages. @brianr. #290

Merged
merged 3 commits into from
Sep 15, 2015

Conversation

jondeandres
Copy link
Contributor

No description provided.

@jondeandres jondeandres force-pushed the send-last-backrace-entry-on-failsafe branch from 9980bee to afb48ab Compare September 11, 2015 15:24
@@ -619,6 +605,33 @@ def send_failsafe(message, exception)
failsafe_payload
end

def failsafe_body(message, exception)
body = 'Failsafe from rollbar-gem. '
log_error "[Rollbar] Sending failsafe response due to #{message}."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log message should probably still be in send_failsafe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jon de Andres added 2 commits September 14, 2015 14:08
bundle install with 1.9.2 and rails30.gemfiles doesn't resolve dependencies.
@jondeandres jondeandres force-pushed the send-last-backrace-entry-on-failsafe branch from 0185922 to d0f505b Compare September 14, 2015 15:06
jondeandres added a commit that referenced this pull request Sep 15, 2015
…safe

Send nearest backtrace entry on failsafe messages. @brianr.
@jondeandres jondeandres merged commit 7a0f5af into master Sep 15, 2015
@jondeandres jondeandres deleted the send-last-backrace-entry-on-failsafe branch September 15, 2015 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants