Add backtrace to exceptions without backtrace. Closes #205. #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return exception.backtrace if exception.backtrace.respond_to?( :map ) | ||
| return [] unless configuration.populate_empty_backtraces | ||
|
|
||
| cleaned_backtrace = caller.reject {|path| path =~ /#{rollbar_gem_dir}/ } |
There was a problem hiding this comment.
Does this reject all rollbar frames anywhere in the stack? I think we should keep the ones that appear in the middle of the stack (i.e. our middleware).
There was a problem hiding this comment.
Good point @brianr.
That's the issue, if we don't clean that filenames we will always show frames from the Rollbar.error() statement. But clean only those frames can be a little tricky.
Would you like to clean it in a smarter way? Not clean? Don't provide this feature?
| @@ -363,6 +360,19 @@ def trace_data(exception) | |||
| } | |||
| end | |||
|
|
|||
| def exception_backtrace(exception) | |||
There was a problem hiding this comment.
Nice. Some comments here would be helpful.
|
@brianr added comments and moved ruby-debug and byebug to Gemfile. |
brianr
added a commit
that referenced
this pull request
Feb 5, 2015
Add backtrace to exceptions without backtrace. Closes #205.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.