Fix internal Rollbar error caused when ActiveRecord was present, but not used #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the ActiveRecord gem was required in a Rails app, but not actually
used or configured (in favor of some other ORM or no ORM), then Rollbar
would internally error whenever it tried to send an exception message.
This was being caused by the person tracking functionality seeing that
ActiveRecord existed, but then it would raise a
ActiveRecord::ConnectionNotEstablished error when it actually tried to
use the connection. This in turn led to a rather non-obvious error in
the logs:
```
[Rollbar] Reporting internal error encountered while sending data to Rollbar.
[Rollbar] Sending payload
[Rollbar] Got unexpected status code from Rollbar api: 422
[Rollbar] Response: {
"err": 1,
"message": "Invalid format. data.context object value found, but a string is required."
}
```
This should fix this person-tracking situation by first checking whether
ActiveRecord is actually connected before trying to do
ActiveRecord-specific functions.
GUI
added a commit
to NREL/api-umbrella-web
that referenced
this pull request
Jan 17, 2015
Basically, seed-fu was requiring activerecord, even though it wasn't being used. This in turn triggered an internal Rollbar error when Rollbar attempted to report exceptions. See: rollbar/rollbar-gem#204
brianr
added a commit
that referenced
this pull request
Jan 20, 2015
Fix internal Rollbar error caused when ActiveRecord was present, but not used
|
Thanks @GUI! Will get a new release out shortly. |
|
Up on rubygems in version 1.4.1. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ActiveRecord gem was required in a Rails app, but not actually used or configured (in favor of some other ORM or no ORM), then Rollbar would internally error whenever it tried to send an exception message. This was being caused by the person tracking functionality seeing that ActiveRecord existed, but then it would raise a ActiveRecord::ConnectionNotEstablished error when it actually tried to use the connection. This in turn led to a rather non-obvious error in the logs:
This should fix this person-tracking situation by first checking whether ActiveRecord is actually connected before trying to do ActiveRecord-specific functions.