Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silence warning when using project_gems= with regexp #120

Merged
merged 1 commit into from
Jun 30, 2014
Merged

silence warning when using project_gems= with regexp #120

merged 1 commit into from
Jun 30, 2014

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jun 30, 2014

fixes warning introduced by #114

NOTE: Dependency.new w/ a regexp is deprecated.
Dependency.new called from /opt/boxen/rbenv/versions/2.1.1/lib/ruby/2.1.0/rubygems/specification.rb:898

@brianr
Copy link
Member

brianr commented Jun 30, 2014

Thanks! We'll review and get this merged, most likely today.

@sbezboro sbezboro merged commit 9db9c61 into rollbar:master Jun 30, 2014
@sbezboro
Copy link
Contributor

Thanks for the PR @grosser! Merged this with a small test addition, and pushed to rubygems as version 0.13.1

@grosser grosser deleted the grosser/silence branch July 11, 2014 19:54
@boone boone mentioned this pull request Oct 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grosser @brianr @sbezboro