Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMethodError: undefined method `send_failsafe' for nil:NilClass #479

Closed
jlhonora opened this issue Jun 2, 2016 · 2 comments
Closed

NoMethodError: undefined method `send_failsafe' for nil:NilClass #479

jlhonora opened this issue Jun 2, 2016 · 2 comments

Comments

@jlhonora
Copy link

jlhonora commented Jun 2, 2016

I'm getting the following error:

NoMethodError: undefined method `send_failsafe' for nil:NilClass
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/rollbar-2.11.3/lib/rollbar/item.rb", line 108, in dump
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/rollbar-2.11.3/lib/rollbar.rb", line 445, in send_item
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/rollbar-2.11.3/lib/rollbar.rb", line 191, in process_item
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/rollbar-2.11.3/lib/rollbar.rb", line 228, in block in process_from_async_handler
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/rollbar-2.11.3/lib/rollbar.rb", line 96, in silenced
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/2.2.0/forwardable.rb", line 188, in silenced
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/rollbar-2.11.3/lib/rollbar.rb", line 226, in process_from_async_handler
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/2.2.0/forwardable.rb", line 188, in process_from_async_handler
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/rollbar-2.11.3/lib/rollbar/delay/sidekiq.rb", line 20, in perform
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/processor.rb", line 152, in execute_job
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/processor.rb", line 134, in block (2 levels) in process
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 128, in block in invoke
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/rollbar-2.11.3/lib/rollbar/plugins/sidekiq/plugin.rb", line 9, in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/newrelic_rpm-3.11.1.284/lib/new_relic/agent/instrumentation/sidekiq.rb", line 33, in block in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/newrelic_rpm-3.11.1.284/lib/new_relic/agent/instrumentation/controller_instrumentation.rb", line 353, in perform_action_with_newrelic_trace
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/newrelic_rpm-3.11.1.284/lib/new_relic/agent/instrumentation/sidekiq.rb", line 29, in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/bundler/gems/sidetiq-979335567ace/lib/sidetiq/middleware/history.rb", line 8, in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/server/active_record.rb", line 6, in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/server/retry_jobs.rb", line 74, in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/server/logging.rb", line 11, in block in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/logging.rb", line 32, in with_context
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/server/logging.rb", line 7, in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 130, in block in invoke
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 133, in call
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/middleware/chain.rb", line 133, in invoke
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/processor.rb", line 129, in block in process
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/processor.rb", line 168, in stats
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/processor.rb", line 128, in process
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/processor.rb", line 80, in process_one
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/processor.rb", line 68, in run
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/util.rb", line 17, in watchdog
  File "/home/ubuntu/.rbenv/versions/2.2.5/lib/ruby/gems/2.2.0/gems/sidekiq-4.1.2/lib/sidekiq/util.rb", line 25, in block in safe_thread

Usually happens between deploys. I wouldn't mind making this small change:

diff --git a/lib/rollbar/item.rb b/lib/rollbar/item.rb
index 0a424eb..e91030d 100644
--- a/lib/rollbar/item.rb
+++ b/lib/rollbar/item.rb
@@ -105,7 +105,7 @@ module Rollbar

       original_size = Rollbar::JSON.dump(payload).bytesize
       final_size = result.bytesize
-      notifier.send_failsafe("Could not send payload due to it being too large after truncating attempts. Original size: #{original_size} Final size: #{final_size}", nil)
+      notifier.send_failsafe("Could not send payload due to it being too large after truncating attempts. Original size: #{original_size} Final size: #{final_size}", nil) if notifier.present?
       logger.error("[Rollbar] Payload too large to be sent: #{Rollbar::JSON.dump(payload)}")

       nil

but it might shadow a bigger issue with it.

Thanks in advance.

@jondeandres
Copy link
Contributor

Hey @jlhonora, thank you very much for opening this issue. I think I've found the reason of this crash. I'll fix this and release a new gem version in few hours ok?

Thanks again.

@jlhonora
Copy link
Author

jlhonora commented Jun 2, 2016

Awesome, thanks for the fast response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants