Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.3.0 and what bout JRuby? #303

Closed
PetrKaleta opened this issue Sep 18, 2015 · 4 comments
Closed

v2.3.0 and what bout JRuby? #303

PetrKaleta opened this issue Sep 18, 2015 · 4 comments

Comments

@PetrKaleta
Copy link

In 2.3.0 you're using Oj gem. Ok, fine, and what about JRuby? You can't use globally gem with C extensions...
@PetrKaleta
Copy link
Author

This is related pull request #300

@PetrKaleta
Copy link
Author

I'll suggest to use MultiJson, it's a good practice instead of being 3rd party JSON lib dependant.

@jondeandres
Copy link
Contributor

@PetrKaleta we used MultiJson but we removed it since it was given us too many different behaviors from customers, some of them configuring it improperly. So we decided to just control ourself how to serialize the payload.

I think we didn't realize this wasn't failing in JRuby, sorry. This has been a misunderstanding with Travis cause we are really excluding JRuby builds there.

We'll fix this in next two days. Sorry for this.

@jondeandres
Copy link
Contributor

@PetrKaleta how 63db163 would work for you?

We hope to merge this today or next working day.

Cheers.

jondeandres added a commit that referenced this issue Sep 30, 2015
@jondeandres
Merge pull request #304 from rollbar/restore-multi_json-and-custom-op…
0a0da3b 
…tions

Restore MultiJson and add custom option modules. Fix #303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jondeandres @PetrKaleta