This repository has been archived by the owner on Jul 23, 2018. It is now read-only.
Fix buildRequestData when req.body is a plain object #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a591716 to
4a6805e
Compare
| for (k in req.body) { | ||
| if (req.body.hasOwnProperty(k)) { | ||
| var hasOwnProperty = typeof req.body.hasOwnProperty === 'function' && req.body.hasOwnProperty(k); |
There was a problem hiding this comment.
Style: Extra ws before req.body.hasOwnProperty(k)
|
Great. LGTM |
4a6805e to
4cf5104
Compare
Some libraries, like [multer](https://github.com/expressjs/multer) create `req.body` in this way: `req.body = Object.create(null)` In that case we cannot call `req.body.hasOwnProperty()`. In this PR we check that `req.body` has `hasOwnProperty` function or the `req.body.constructor` is undefined, so it is a plain `Object` and we can be sure that the keys are part of the body Fixes #68
4cf5104 to
df60735
Compare
jondeandres
added a commit
that referenced
this pull request
Feb 18, 2016
Fix buildRequestData when req.body is a plain object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries, like multer create
req.bodyin this way:req.body = Object.create(null)In that case we cannot call
req.body.hasOwnProperty(). In this PR we check thatreq.bodyhashasOwnPropertyfunction or thereq.body.constructoris undefined, so it is a plainObjectand wecan be sure that the keys are part of the body