Skip to content

Commit

Permalink
Add fields to the scrubber field set.
Browse files Browse the repository at this point in the history
  • Loading branch information
csaba-ilonka-rollbar committed Nov 20, 2023
1 parent e9c26fe commit 94d9f31
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 25 deletions.
20 changes: 13 additions & 7 deletions Rollbar/RollbarDataScrubbingHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,19 @@ public virtual ISet<string> GetDefaultFields()
return new HashSet<string>(
new[]
{
"Password",
"passwd",
"confirm_password",
"password_confirmation",
"accessToken",
"auth_token",
"authentication",
"Password",
"password",
"passwd",
"confirm_password",
"password_confirmation",
"AccessToken",
"accessToken",
"auth_token",
"Authentication",
"authentication",
"Authorization",
"authorization",
"Secret",
"secret",
}
);
Expand Down
36 changes: 18 additions & 18 deletions SdkCommon.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,33 +13,33 @@
<GenerateAssemblyInfo>true</GenerateAssemblyInfo>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
</PropertyGroup>

<ItemGroup>
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>UnitTest.$(AssemblyName)</_Parameter1>
</AssemblyAttribute>
</AssemblyAttribute>
<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
<_Parameter1>UnitTest.RollbarTestCommon</_Parameter1>
</AssemblyAttribute>
</AssemblyAttribute>
</ItemGroup>

<PropertyGroup Label="SDK Release Essential Info">
<SdkVersion>5.2.0</SdkVersion> <!-- Required: major.minor.patch -->
<SdkVersion>5.2.2</SdkVersion> <!-- Required: major.minor.patch -->
<SdkVersionSuffix></SdkVersionSuffix> <!-- Optional. Examples: alpha, beta, preview, RC etc. -->
<SdkLtsRelease>false</SdkLtsRelease> <!-- Optional. Examples: false (default) or true. -->
<SdkReleaseNotes> <!-- Required -->

feat: resolve #630 - No option to set code_version at the config level in v5 of the SDK
fix: resolve #644 - Scrub access token in the message payload.

</SdkReleaseNotes>
</SdkReleaseNotes>

<!--
Release Notes Tagging Conventions:
==================================
1. Every entry within the PackageReleaseNotes element is expected to be started with
at least one of the tags listed:
feat: A new feature
fix: A bug fix
docs: Documentation only changes
Expand All @@ -48,18 +48,18 @@
perf: A code change that improves performance
test: Adding or modifying unit test code
chore: Changes to the build process or auxiliary tools and libraries such as documentation generation, etc.
2. Every entry within the PackageReleaseNotes element is expected to be tagged with
EITHER
2. Every entry within the PackageReleaseNotes element is expected to be tagged with
EITHER
"resolve #GITHUB_ISSUE_NUMBER:" - meaning completely addresses the GitHub issue
OR
OR
"ref #GITHUB_ISSUE_NUMBER:" - meaning relevant to the GitHub issue
depending on what is more appropriate in each case.
-->

</PropertyGroup>


<PropertyGroup Label="SDK Common Assembly Info and NuGet Packaging Info" >

<PackageReleaseNotes>$(SdkReleaseNotes)</PackageReleaseNotes>
Expand All @@ -83,8 +83,8 @@
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
</PropertyGroup>

<PropertyGroup
Label="SDK Common Assembly Info and NuGet Packaging Info for non-LTS releases"
<PropertyGroup
Label="SDK Common Assembly Info and NuGet Packaging Info for non-LTS releases"
Condition="'$(SdkLtsRelease)'=='true'">
<InformationalVersion>LTS-$(SdkVersion)-$(SdkVersionSuffix)</InformationalVersion>
<ProductVersion>LTS-$(SdkVersion)-$(SdkVersionSuffix)</ProductVersion>
Expand Down Expand Up @@ -120,6 +120,6 @@

<!--REFERENCES:
https://docs.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props
-->
</Project>

0 comments on commit 94d9f31

Please sign in to comment.