Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the closing of the application faster at the end of the tests #273

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

chrisdp
Copy link
Collaborator

@chrisdp chrisdp commented Feb 10, 2024

When testing on some applicaitons the app would hang for many seconds before closing with the keepAppOpen setting set to true. This will make sure the main function that is calling rooibos_init is also ended right away.

Failing unit tests are fixed in #271

@chrisdp chrisdp added the enhancement New feature or request label Feb 10, 2024
@luis-j-soares
Copy link
Contributor

Won't this cause issues for cases like the one below?

sub main(args as dynamic)
    doSomeStuffBeforeRooibosInitialises()

    Rooibos_init()

    doSomeStuffAfterRooibosEnds() ' <-- this won't get called
end sub

@chrisdp
Copy link
Collaborator Author

chrisdp commented Feb 10, 2024

Won't this cause issues for cases like the one below?

sub main(args as dynamic)
    doSomeStuffBeforeRooibosInitialises()

    Rooibos_init()

    doSomeStuffAfterRooibosEnds() ' <-- this won't get called
end sub

It would prevent that. That was actually my goal. As the app is actually left in this odd running state even with this flag turned on.

If you want to do something after rooibos I think you shouldn't have this flag on as the flag says close the app or leave it open.

@chrisdp
Copy link
Collaborator Author

chrisdp commented Feb 12, 2024

@georgejecook @luis-soares-sky What are your thoughts on the above comment?

@chrisdp chrisdp merged commit 9471f48 into master Feb 13, 2024
10 checks passed
@chrisdp chrisdp deleted the faster-applcation-closing branch February 13, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants