chore: update eslintrc, drop nodev12 support (#156)

roikoren755 · May 22, 2022 · 8591236 · 8591236
1 parent 28895f2
commit 8591236
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 30 deletions.
diff --git a/.changeset/late-items-sin.md b/.changeset/late-items-sin.md
@@ -0,0 +1,5 @@
+---
+'eslint-plugin-es-roikoren': major
+---
+
+chore: drop node v12 support
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -9,7 +9,6 @@ module.exports = {
     jsxPragma: null,
   },
   reportUnusedDisableDirectives: true,
-  plugins: ['import'],
   settings: {
     'import/parsers': { '@typescript-eslint/parser': ['.ts'] },
     'import/resolver': { node: { extensions: ['.ts', '.js', '.json'] }, typescript: {} },
@@ -36,7 +35,6 @@ module.exports = {
     'max-lines': ERROR,
     'no-bitwise': ERROR,
     'no-caller': ERROR,
-    'no-case-declarations': ERROR,
     'no-console': ERROR,
     'no-constant-binary-expression': ERROR,
     'no-constructor-return': ERROR,
@@ -173,50 +171,24 @@ module.exports = {
 
     'import/extensions': [ERROR, { json: 'always' }],
     'import/first': ERROR,
-    'import/named': ERROR,
-    'import/namespace': ERROR,
     'import/newline-after-import': ERROR,
     'import/no-cycle': ERROR,
     'import/no-default-export': ERROR,
     'import/no-duplicates': ERROR,
     'import/no-extraneous-dependencies': ERROR,
-    'import/no-unresolved': ERROR,
     'import/no-useless-path-segments': ERROR,
     'import/order': [
       ERROR,
       { alphabetize: { order: 'asc' }, 'newlines-between': 'always', warnOnUnassignedImports: true },
     ],
 
-    'unicorn/better-regex': ERROR,
-    'unicorn/catch-error-name': ERROR,
-    'unicorn/consistent-function-scoping': ERROR,
-    'unicorn/explicit-length-check': ERROR,
-    'unicorn/filename-case': ERROR,
     'unicorn/import-index': ERROR,
-    'unicorn/import-style': ERROR,
     'unicorn/no-array-for-each': OFF,
     'unicorn/no-array-reduce': OFF,
-    'unicorn/no-array-callback-reference': ERROR,
     'unicorn/no-null': OFF,
-    'unicorn/no-object-as-default-parameter': ERROR,
-    'unicorn/no-process-exit': ERROR,
-    'unicorn/no-unreadable-array-destructuring': ERROR,
-    'unicorn/no-useless-undefined': ERROR,
-    'unicorn/prefer-add-event-listener': ERROR,
-    'unicorn/prefer-array-flat': ERROR,
     'unicorn/prefer-module': OFF,
-    'unicorn/prefer-negative-index': ERROR,
     'unicorn/prefer-node-protocol': OFF,
-    'unicorn/prefer-number-properties': ERROR,
-    'unicorn/prefer-object-from-entries': ERROR,
-    'unicorn/prefer-optional-catch-binding': ERROR,
-    'unicorn/prefer-query-selector': ERROR,
-    'unicorn/prefer-set-has': ERROR,
-    'unicorn/prefer-spread': ERROR,
-    'unicorn/prefer-string-slice': ERROR,
-    'unicorn/prefer-ternary': ERROR,
     'unicorn/prevent-abbreviations': OFF,
-    'unicorn/template-indent': ERROR,
   },
   overrides: [
     { files: ['./.commitlintrc.js', './.eslintrc.js', './.prettierrc.js'], rules: { 'no-undef': OFF } },

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -42,7 +42,7 @@ jobs:
     strategy:
       matrix:
         eslint: [7, 8]
-        node: [12, 14, 16, 18]
+        node: [14, 16, 18]
         os: [ubuntu-latest]
         include:
           # On other platforms
@@ -63,11 +63,12 @@ jobs:
           node-version: ${{ matrix.node }}
           cache: npm
       - name: Install NPM v8
-        if: matrix.node != 16
+        if: matrix.node != 16 && matrix.node != 18
         run: npm i -g npm
       - name: Install Packages
         run: npm i
       - name: Install ESLint ${{ matrix.eslint }}
+        if: matrix.eslint != 8
         run: npm i eslint@${{ matrix.eslint }} -D
       - name: Test
         run: npm test