Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close does not like filenames with extensions #2

Closed
jfrankenau opened this issue Feb 28, 2017 · 1 comment
Closed

Close does not like filenames with extensions #2

jfrankenau opened this issue Feb 28, 2017 · 1 comment

Comments

@jfrankenau
Copy link

I have set PASSWORD_STORE_TOMB_FILE="$HOME/password.tomb".

With this setting pass close calls tomb close with the argument password.tomb, see here. However, tomb list shows that the opened tomb is instead just called password. Thus pass-tomb will fail to close the password tomb.
roddhjav added a commit that referenced this issue Feb 28, 2017
@roddhjav
Add support for password tomb named with extension. See #2
69b3d74
@roddhjav
Copy link
Owner

TOMB_NAME=${TOMB_FILE##*/} only retrieve the base name of the tomb file. I added the extension detection. In order to keep the track of this in the future, I also changed the tomb name in the tests.

Thanks again for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfrankenau @roddhjav