Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt "password-store" #53

Closed
phillxnet opened this issue Nov 30, 2023 · 1 comment
Closed

Adopt "password-store" #53

phillxnet opened this issue Nov 30, 2023 · 1 comment

Comments

@phillxnet
Copy link
Member

Regarding in-development changes in rockstor-core re: Adopt dedicated secrets management library in current draft status PR: rockstor/rockstor-core#2756 we have a new OS dependency to provide secrets storage. The proposal is as follows:

password-store: https://www.passwordstore.org/

Authored/maintained by Jason A. Donenfeld of wireguard fame.

Requiring a new dependency across all targets, and likely some rpmbuild spec file scriptlet additions (as yet unclear).
phillxnet added a commit to phillxnet/rockstor-rpmbuild that referenced this issue Dec 2, 2023
@phillxnet
Adopt "password-store" rockstor#53
b00dca1 
Align with rockstor-core changes regarding 'pass' adoption
for secrets storage. Install via OS provided 'password-store'.
## Includes
- Additional minimal setup of GNUPG & pass to enable %check
scriptlet function as we need a running Django instance for
our tests.
- BuildRequires 'password-store' OS package for 'pass':
required for %check scriptlet.
- Requires 'password-store' OS package on all OS targets.
- Minor README.md typos.
phillxnet added a commit that referenced this issue Dec 4, 2023
@phillxnet
Merge pull request #54 from phillxnet/53-Adopt-password-store
b2f3a45 
Adopt "password-store" #53
@phillxnet phillxnet mentioned this issue Dec 4, 2023
Merged
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet